Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added object type for array #575

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pooja1pathak
Copy link
Collaborator

Proposed changes

Added object(ignored) type for array. Fix for issue #147

Types of changes

What types of changes does your code introduce to the project: Put
an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my
    feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in
    downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion
by explaining why you chose the solution you did and what alternatives
you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@pooja1pathak
Copy link
Collaborator Author

@c0c0n3 @chicco785 Please confirm about the changes. Does it fits our need or I need to look into other approach.
I tried to fix failing test cases but unable to do so. I will update the test cases after changes are confirmed and CircleCI issue is fixed.

@chicco785
Copy link
Contributor

@pooja1pathak please also add tests and update the changelog. many thanks.

@chicco785
Copy link
Contributor

the new type breaks something in the code

@pooja1pathak
Copy link
Collaborator Author

the new type breaks something in the code

Yes, I am looking into it. I'll update once I fix this

@c0c0n3 c0c0n3 self-assigned this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants