Resolve #2971: Improve table header text contrast for accessibility #2972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this is really interesting! However, it seems to introduce a new issue. When sorting was active, the column was highlighted with a darker font, but now everything is dark, making it difficult to tell which column is being sorted. How about using opacity to improve visibility? What do you think? It would be great to simplify our SCSS theme and rely more on Bootstrap, where we could just increase the minimum contrast variable—but that’s beyond the scope of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2971
Proposed Changes
text-darkclass to<th>elements to improve the contrast and accessibility of table headers.text-mutedclass withtext-darkon<a>elements to enhance link visibility and readability.