Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display teleburn address #4093

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

raphjaph
Copy link
Collaborator

Nobody uses this and it confuses people. This PR just doesn't display the address on the frontend, all other teleburn logic remains.

@raphjaph raphjaph requested a review from casey November 21, 2024 09:17
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but tests need fixing. Any changed tests should use the new style.

Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raphjaph raphjaph enabled auto-merge (squash) November 25, 2024 22:54
@raphjaph raphjaph disabled auto-merge November 25, 2024 22:55
@raphjaph raphjaph enabled auto-merge (squash) November 25, 2024 22:55
@raphjaph raphjaph merged commit 5ac126d into ordinals:master Nov 25, 2024
5 checks passed
@rot13maxi
Copy link
Contributor

end of an era.

good change tho.

@casey
Copy link
Collaborator

casey commented Nov 26, 2024

Yah. I think the main thing is that there's too much stuff on /inscription. The ethereum teleburn address is only the first victim.

@raphjaph raphjaph deleted the dont-display-teleburn branch December 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants