Wait for wallet to load #4095
Merged
Wait for wallet to load #4095
+46
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's: |
casey
reviewed
Dec 10, 2024
src/wallet.rs
Outdated
| .bitcoin_rpc_client(Some(name.clone()))? | ||
| .call::<serde_json::Value>("importdescriptors", &[serde_json::to_value(descriptors)?])?; | ||
| loop { | ||
| match settings |
There was a problem hiding this comment.
This seems wrong, shouldn't we only ever call import descriptors once, as opposed to in a loop?
casey
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4091 and #4111.
@gmart7t2 This catches a couple of errors that usually occur when the wallet takes a long time to load. It should now wait until a wallet or descriptor is finished loading before proceeding.
Do you know by chance what the Bitcoin Core error code or message is if a descriptor for a wallet is still loading?