Add function to calculate rune unlock height #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I know what the issue is. PR opened here: casey#3 👍 |
|
@t4t5 Nice, that helps! I tweaked it a little bit to avoid floating point math. I think this version is now much less mysterious. |
raphjaph
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
Rune::unlock_height. This works but makes me nervous. I noticed that my height calculation was one too high whenever we were 0/4, 1/4, 2/4, or 3/4ths of the way through an interval of runes with a given length. So I just fudged it and subtracted one in those cases.I've exhaustively tested lengths 1 through 7, and they're all correct. (Checked by cross checking with asserts that the result of
Rune::unlock_heightmatchesRune::minimum_at_height.) However, I'm worried that this pattern is actually the result of some deep number theory harmonic integer sequence or something, and is somehow wrong for larger intervals.