Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sat values to address response (#3809) #4101

Closed
wants to merge 2 commits into from

Conversation

cryptoquick
Copy link
Contributor

@cryptoquick cryptoquick commented Nov 25, 2024

Returns the sat value of each individual output in the address response. See issue: #3809

@cryptoquick
Copy link
Contributor Author

Not sure how this test failure is related...
https://github.com/ordinals/ord/actions/runs/12012245784/job/33483021419?pr=4101#step:5:721

@raphjaph
Copy link
Collaborator

I think that was just an intermittent failure.

@raphjaph
Copy link
Collaborator

We already have the sat_balance so I'm unsure what this would gives us. I think by sats I meant rare sats (sats tracked by ord).

@cryptoquick
Copy link
Contributor Author

Sure, this just returns the sat value of each individual UTXO, since we already have that information, it's just all added together currently. Does that makes sense?

@zk-bits
Copy link

zk-bits commented Dec 2, 2024

Getting individual utxo values would be super helpful and mimics esplora more closely @raphjaph

@raphjaph
Copy link
Collaborator

raphjaph commented Dec 4, 2024

This is what the /outputs/<ADDRESS> endpoint is for. The /address/<ADDRESS> endpoint should only show aggregated information.

@raphjaph raphjaph closed this Dec 4, 2024
@cryptoquick
Copy link
Contributor Author

We're currently running ord 0.21.0 in production, and that endpoint doesn't seem to be working. Locally against regtest I see it working on 0.21.3. Is that API new, or do you think our server might be misconfigured?

@cryptoquick
Copy link
Contributor Author

Ah, I see in the release notes this new outputs API just came out last month in 0.21.3. Thanks, that should do just fine!

@cryptoquick cryptoquick deleted the HB/return-utxo-value branch December 4, 2024 19:40
@raphjaph
Copy link
Collaborator

raphjaph commented Dec 4, 2024

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants