Skip to content

Commit

Permalink
fix: ignoring the annoying Svelte a11y-click-events-have-key-events
Browse files Browse the repository at this point in the history
… warnings

We explain in the code that this will be fixed in the future as part of #11.

Even though in general we should keep the warning in the console until they're fixed,
the library users should not be annoyed in their own builds.

Refs: #11 (comment)
  • Loading branch information
Tal500 committed Feb 26, 2023
1 parent 446159e commit 7d9b872
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/lib/Pane.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,9 @@

{#if !gathering}
<!-- Splitter -->
<!-- TODO: Support aria role="separator" and make this a focusable separtor. Sources:
* https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/roles/separator_role
* https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/
-->
{#if $veryFirstPaneKey !== key || $showFirstSplitter}
<!-- this a11y issue is known, and will be taken care of as part of the a11y feature issue in #11 -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
class="splitpanes__splitter {isSplitterActive ? 'splitpanes__splitter__active' : ''}"
on:mousedown={carefullClientCallbacks('onSplitterDown')}
Expand All @@ -118,6 +116,8 @@
{/if}

<!-- Pane -->
<!-- this a11y issue is known, and will be taken care of as part of the a11y feature issue in #11 -->
<!-- svelte-ignore a11y-click-events-have-key-events -->
<div
class={`splitpanes__pane ${clazz || ''}`}
bind:this={element}
Expand Down

0 comments on commit 7d9b872

Please sign in to comment.