-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessability #11
Comments
Tnx, will try to work on this next week. Forgot to mention:
|
Hi, I also get this annoying clutter in Terminal, which I can't figure out how to "ignore": |
I agree that it's annoying. Since we are aware of this warning and this is WIP, I guess we shall use the "svelte a11y ignore" tags: We should comment in the code that the issues are know and reported on this issue, i.e. add next to the tags: <!-- this a11y are known, and will be taken care of as part of the a11y feature issue in #11 --> |
… warnings We explain in the code that this will be fixed in the future as part of #11. Even though in general we should keep the warning in the console until they're fixed, the library users should not be annoyed in their own builds. Refs: #11 (comment)
This comment is fixed now by 7d9b872. |
Following #9, we need to have accessibility for the splitter, by ARIA attributes and by keyboard interaction.
separator
roleThere are two types of splitters - non-focusable(i.e. static) and focusable(interactive). Read source 1 for telling which aria attributes should be on each on.
I believe that a splitter in this library is consider to be non-focusable(i.e. static) if and only if
minSize===maxSize
, as you can see the example in this library docs.Focusable (interactive) splitter in this library
tabindex = 0
. Notice that non-focusable(i.e. static) splitters should not be focusable at all!F6
(cycle between panes) is a really cool one in my opinion. I think that each pane should have the HTML attributetabindex = -1
(meaning focusable, but only by script), and pressingF6
will detect which pane has the current focus, and will cycle through the panes and set the focus on the next one. I believe, although not written by the official standards, the if the user pressShift + F6
, then it should cycle backwards, as theShift
key invert the operation.F6
, I believe that a special care should be for nested panes. I think the correct way to deal with this issue is to cycle only through the leaf panes(meaning, on on panes which don't have a nested SplitPanes component inside of them).I think we need to be careful and clever for dealing with Svelte context API for passing sizes data from SplitPanes to Pane components.
I have an idea how to implement it, just need a green light to do so.
The text was updated successfully, but these errors were encountered: