Create CacheStore, a merger of OreSatFileCache and a CFDP filestore #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filestore specifically as implemented though cfdp-py, which has some "enhancements" to the base protocol spec. The defined API for an OreSatFileCache was insufficient to implement the filestore API, so I had build it on top of the internals. Special considerations: - Locking with a non-reentrant lock meant the API generally couldn't be reused internally - ._data needed to be kept up-to-date and in-order, this was aided by the bisect module - There are no directories in an OreSatFileCache so they're ignored in paths provided, only taking the basename portions. Additionally directory operations are no-ops except for list_directory which lists all files in the cache directory (not just those known to the cache) - All files should maintain the OreSatFile filename format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filestore specifically as implemented though cfdp-py, which has some "enhancements" to the base protocol spec. The defined API for an OreSatFileCache was insufficient to implement the filestore API, so I had build it on top of the internals. Special considerations: