Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FSMBehavior): Prevent state changes out of FINAL state #336

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix(FSMBehavior): Prevent state changes out of FINAL state #336

merged 1 commit into from
Jan 3, 2025

Conversation

ettersi
Copy link
Collaborator

@ettersi ettersi commented Dec 9, 2024 •
edited
Loading

Fixes #324 by blocking state changes out of the FINAL state.

To be ported to master once finalised.

@ettersi ettersi self-assigned this Dec 9, 2024
@ettersi ettersi marked this pull request as ready for review January 3, 2025 06:29
@ettersi ettersi requested a review from mchitre January 3, 2025 06:30
@ettersi
Copy link
Collaborator Author

ettersi commented Jan 3, 2025

Just to be clear, my intention here is to merge this PR into master as a way of forward-porting the fix, but keep the patch-v1.12.x branch alive and make a separate v1.12.4 release off of it containing this PR and #337.

@ettersi ettersi merged commit 3aa68a3 into master Jan 3, 2025
2 checks passed
@ettersi ettersi deleted the patch-v1.12.x branch January 3, 2025 09:51
@ettersi ettersi restored the patch-v1.12.x branch January 3, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchitre mchitre mchitre approved these changes

Assignees

@ettersi ettersi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fsm.setNextState() overwrites fsm.terminate()
2 participants
@ettersi @mchitre