Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #541 - US-EIN searchable register update #542

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Fix #541 - US-EIN searchable register update #542

merged 3 commits into from
Aug 23, 2023

Conversation

emmajclegg
Copy link
Collaborator

@emmajclegg emmajclegg commented Aug 15, 2023 •
edited
Loading

Fix #541

  • Searchable SEC register link added to "Find and use identifiers" section (overwriting previous non-searchable link)
  • Other US-EIN page links checked. Note duplicate reference found (no.3), suspected to be incorrect, but unable to find correct information source online.

@kd-ods kd-ods self-requested a review August 23, 2023 11:32
@kd-ods
Copy link
Contributor

kd-ods commented Aug 23, 2023

@emmajclegg - is this ready for review? I've assumed so and added myself as a reviewer.

@emmajclegg
Copy link
Collaborator Author

yes @kd-ods - ready for review, thanks

kd-ods
kd-ods previously approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@kd-ods kd-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your edits are fine, @emmajclegg . I'm going to edit the description to deal with the problematic reference before merging.

@kd-ods kd-ods self-requested a review August 23, 2023 13:12
@kd-ods kd-ods merged commit ff313a7 into main Aug 23, 2023
4 of 6 checks passed
@kd-ods kd-ods deleted the emmajclegg-US-EIN-fix-541 branch August 23, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kd-ods kd-ods kd-ods approved these changes

Assignees

@kd-ods kd-ods

@emmajclegg emmajclegg

Labels
IATI update list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UPDATE: US-EIN searchable register link
2 participants
@emmajclegg @kd-ods