-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update es-mdj.json (implements #558) #561
Conversation
Updated URLs as previous pages were moved without a redirect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this url http://www.mjusticia.gob.es/cs/Satellite/Portal/es/areas-tematicas/registros (which appears a few times in the entry) has been updated.
Also, the value for name.local is given as "es" whereas it should be "Ministerio de Justicia" and name.en should be "Ministry of Justice, Spain".
Could you please update the lastUpdated field too?
It doesn't look as though I have included any updates to the record! |
Making changes that were missed previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggested edits. Otherwise this looks ready to go.
Co-authored-by: kd-ods <[email protected]>
Co-authored-by: kd-ods <[email protected]>
@kd-ods Thank you - I've committed those two suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I'll merge and update the front-end.
Updated URLs as previous pages were moved without a redirect