Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use cdn-us1 (Cloudflare + Backbaze) for the actual versions #87

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Don't use cdn-us1 (Cloudflare + Backbaze) for the actual versions #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/servers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ export async function getServersList(request: Request) {
case 'NA': // North America
case 'SA': // South America
case 'OC': // Oceania
servers = [SERVER.backblaze, SERVER.us_east1, SERVER.us_west1, SERVER.uk1, SERVER.nl1, SERVER.planet].filter(
(server) => DATA_VERSIONS.slice(-server.dataVersions).includes(dataVersion),
servers = [SERVER.us_east1, SERVER.us_west1, SERVER.uk1, SERVER.nl1, SERVER.planet].filter((server) =>
DATA_VERSIONS.slice(-server.dataVersions).includes(dataVersion),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR, we had an archive of all map data versions on backblaze?
If I request an old data version, will get an empty list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backblaze stays as an archive:

meta/src/servers.ts

Lines 141 to 143 in ecc91e7

// Only fallback to the archive in the US if nothing was found closer.
if (servers.length == 0 && DATA_VERSIONS.slice(-SERVER.backblaze.dataVersions).includes(dataVersion)) {
servers = [SERVER.backblaze];

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that the same logic is needed for NA, SA, OC... I will take a look tomorrow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rtsisyk @vng почему отрубили CF для США? Если жалобы были только из южной америки. Там 90+% всего трафика шло, помимо наших серверов в США.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нормально, посмотрим как будет. Очевидно что если клаудфлар тормозит в ЛАТАМ, он так же будет тормозить везде.

  • клаудфлар дает самый быстрый пинг (очевидно)
  • iOS загрузчик выбирает именно его и только
  • потом он начинает качать из своих "каких-то там" нодов, что я вижу только тормоза

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vng не очевидно, что клаудфлар будет так же тормозить везде. У них много серверов в США и Канаде, там основные их клиенты. И никто ещё из США не жаловался на такие тормоза. Поэтому обрубание канала в США из-за проблем в Аргентине считаю не обоснованным, чрезмерным и рискованным шагом.

);
break;
default:
Expand Down
Loading