Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TitanicDataset EDA MVP #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sxdave
Copy link

@sxdave sxdave commented Sep 26, 2022

No description provided.


option = st.selectbox('Select a graph', ['Pairplot', 'Survived Histogram', 'Survived w/ Passenger Class Boxplot','Scatterplot'])

if option == 'Survived Histogram':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great candidate for a switch statement !

st.table(df.iloc[0:5])

#Dropping unneeded columns ("Location, Title, Cabin, PassengerId")
df = df.drop(columns=['Location Embarked', 'Title', 'Cabin', 'PassengerId'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend using inplace=True here as an argument to eliminate redundancy

Copy link
Contributor

@mbcutts mbcutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments on code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants