fix(remote) Fix detection of GitLab merge request sha #968
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitLabMergeRequest::merge_commit()
now returns the commit's sha instead ofNone
if the Merge Request was not merged using a merge commit but with fast-forward.Motivation and Context
In the generation of the changelog commits were not linked to their GitLab MR if the commit was merged using fast-forward.
This change allows to identify the corresponding GitLab MR independently if the MR was merged with a merge commit or with fast-forward.
How Has This Been Tested?
Existing tests are sufficient and still pass.
Screenshots / Logs (if applicable)
Types of Changes
Checklist: