test(x/interchainquery): directly assert AppModuleBasic.DefaultGenesi…

…s return non-nil JSON

This change tightens the test by directly unit testing that
AppModuleBasic.DefaultGenesis returns a non-nil result.
The test in quicksilver-zone#1666 is an outward API invocation but with
the layers of indirection above, this code down below
could change without notice, preventing effective testing
and making for code rot.

Updates issue quicksilver-zone#1666
Updates PR quicksilver-zone#1667

x/interchainquery/genesis_test.go

@@ -93,3 +93,12 @@ func newSimAppPath(chainA, chainB *ibctesting.TestChain) *ibctesting.Path {
 
 	return path
 }
+
+// Assert to ensure that there is no panic on directly invoking .DefaultGenesis on AppModuleBasic
+// as previously report in https://github.com/quicksilver-zone/quicksilver/issues/1666
+func (s *InterChainQueryTestSuite) TestAssertAppModuleBasicMarshalNonNilJSON() {
+        app := s.GetSimApp(s.chainA)
+        blob := app.DefaultGenesis(app.AppCodec)
+        s.True(blob != nil, "the JSON cannot be nil")
+        s.True(len(blob) > 1, "the length must be non-empty")
+}