Merge pull request #165 from orkes-io/fix/support-empty-redis-passwor…

…d-upgrades Support empty redis upgrades and human tasks
orkes-io · Dec 2, 2024 · e55a9e3 · e55a9e3
2 parents e39d7ea + dc57541
commit e55a9e3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/charts/orkes-conductor/templates/deployment.yaml b/charts/orkes-conductor/templates/deployment.yaml
@@ -274,6 +274,8 @@ spec:
               value: {{ .Values.app.workflowExecutionLockEnabled | quote }}
             - name: conductor.api.ratelimiter.enabled
               value: {{ .Values.app.apiRateLimiterEnabled | quote }}
+            - name: conductor.human-task.enabled
+              value: {{ .Values.app.humanTasksEnabled | default "false" | quote }}
             - name: LOCAL_HOST_IP
               valueFrom:
                 fieldRef:

diff --git a/charts/orkes-conductor/templates/secret.yaml b/charts/orkes-conductor/templates/secret.yaml
@@ -21,7 +21,7 @@ metadata:
 type: Opaque
 data:
   redisHosts: {{ $redisHosts | b64enc }}
-  redisPassword: {{ .Values.redis.password | default "" | b64enc }}
+  redisPassword: {{ .Values.redis.password | default "" | b64enc | quote }}
   postgresPassword: {{ .Values.postgres.password | default "" | b64enc }}
   securityJwtSecret: {{ .Values.security.jwt.secret | default "" | b64enc }}
   {{- if .Values.security.auth0 }}

diff --git a/charts/orkes-conductor/values.yaml b/charts/orkes-conductor/values.yaml
@@ -37,6 +37,7 @@ app:
     maxTaskInWorkflowExecution: "1000"
     maxTaskInWorkflowDefinition: "1000"
   apiRateLimiterEnabled: "true"
+  humanTasksEnabled: "false"
   # documentStoreS3BucketName: Required if archiveStoreType = s3
   documentStoreS3BucketName:
   # documentStoreAzureBlobContainerName, documentStoreAzureBlobEndpoint: Required if archiveStoreType = azureblob