New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace compress/zlib with compress/flate for the encoder #5

Open

whichxjy wants to merge 1 commit into orlade:master from whichxjy:master

whichxjy commented Dec 20, 2023

This PR replaces compress/zlib module with compress/flate. It use the deflate algorithm for encoder directly instead of using the zlib.

Take this PlantUML text for example:

@startuml
Bob -> Alice : hello
@enduml

When the encoder uses compress/zlib, it would be encoded as UDfoA2v9B2efpStXSifFKj2rKt3CoKnELR1Io4ZDoSddSaZDIodDpG44003___W93C00. But https://www.plantuml.com/plantuml/png/UDfoA2v9B2efpStXSifFKj2rKt3CoKnELR1Io4ZDoSddSaZDIodDpG44003___W93C00 is invalid.

When the encoder uses compress/flate, it would be encoded as SYWkIImgAStDuNBAJrBGjLDmpCbCJbMmKiX8pSd9vt98pKifpSq11000__y0. And https://www.plantuml.com/plantuml/png/SYWkIImgAStDuNBAJrBGjLDmpCbCJbMmKiX8pSd9vt98pKifpSq11000__y0 is valid.


          Replace compress/zlib with compress/flate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet