Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement power spectrum density for filtering #13

Merged
merged 18 commits into from
Jun 19, 2024
Merged

Implement power spectrum density for filtering #13

merged 18 commits into from
Jun 19, 2024

Conversation

KedoKudo
Copy link
Contributor

This PR introduces the following changes:

  • Implemented power spectrum based hard thresholding and wiener filtering.
  • Add new example notebooks to show case the usage.
  • Simplify the top level API for regular users.
  • Remove outdated functions.
  • New modes available:
    • full: this is based on the 2020 paper which consists of six steps
    • simple: this is replacing the hard thresholding in full with a FFT based notch filtering for faster noise free pilot estimate.
    • express: this is based on the 2007 paper (two steps) and replacing the collaborative hard thresholding with a FFT based notch filter.

Testing instructions:

  • Clone the repo and checkout the branch, make sure the testing data is also pulled via git submodule
  • Run the three notebooks in the notebook folder
  • Run the unit test with pytest -v at the root of the repo

EWM Story: 5228

@KedoKudo KedoKudo self-assigned this Jun 18, 2024
Copy link

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests and the python notebooks complete without error

Copy link

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@KedoKudo KedoKudo merged commit 9119be1 into next Jun 19, 2024
3 checks passed
@KedoKudo KedoKudo deleted the imp_nps branch June 21, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants