Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multi-scale vertical streak removal quality #29

Merged
merged 8 commits into from
Aug 28, 2024
Merged

Improve multi-scale vertical streak removal quality #29

merged 8 commits into from
Aug 28, 2024

Conversation

KedoKudo
Copy link
Contributor

This PR introduces the following changes:

  • Replace cryptic 1d scaling functions with readable 2D interpolation functions when dumping between scales
  • Fix multi-scale calculation, improve its logic and switch to use the new scaling functions
  • Added new improved method to provide noise free estimate (piece-wise median filtering with blending)
  • Update notebooks demo with updated functions
  • Fix unit tests

Test instructions

  • Check out the feature branch on a GPU system
  • Run the example notebook
  • Run the unit tests

EWM item: item 6102

@KedoKudo KedoKudo self-assigned this Aug 12, 2024
@KedoKudo KedoKudo merged commit 1eb54f2 into next Aug 28, 2024
3 checks passed
@KedoKudo KedoKudo deleted the troubleshoot_ms_denoise branch August 28, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterfpeterson peterfpeterson peterfpeterson approved these changes

Assignees

@KedoKudo KedoKudo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KedoKudo @peterfpeterson