Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate prototype code #3

Merged
merged 16 commits into from
May 15, 2024
Merged

Migrate prototype code #3

merged 16 commits into from
May 15, 2024

Conversation

KedoKudo
Copy link
Contributor

@KedoKudo KedoKudo commented May 7, 2024

This PR is migrating the prototype code from TomoArtifactBenchPy to this repo, including:

  • all prototype source files
  • all prototype unit tests
  • new unit test files
  • new synthetic data for development and testing
  • new example notebook for demo

Testing instructions

  • On a GPU node, create a conda environment using the new environment.yml file
  • Perform editable install with pip install -e .
  • At the root of the repo, run all unit test with pytest -v tests/unit, and all tests should be passing
  • Start the notebook notebooks/example.ipynb, and step through the notebook, and you should be able to go through all cells and get the following results.
    image

EWM Story 4914

Note: the added files are just prototype, and we clearly need to improve the denoising quality further to match the close source one.

@KedoKudo KedoKudo self-assigned this May 7, 2024
@KedoKudo KedoKudo changed the title [WIP] Migrate prototype code Migrate prototype code May 9, 2024
@KedoKudo KedoKudo requested a review from jmborr May 10, 2024 14:09
@KedoKudo KedoKudo merged commit 937a529 into next May 15, 2024
1 check passed
@KedoKudo KedoKudo deleted the add_src_code branch May 15, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants