Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log file entry to backend engine #297

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Add log file entry to backend engine #297

merged 3 commits into from
Mar 8, 2024

Conversation

KedoKudo
Copy link
Contributor

@KedoKudo KedoKudo commented Mar 8, 2024

This PR introduces the following changes:

  • Allow user to specify a log file to duplicate logging stream.
  • Example json file is updated to reflect the change.

EWM item: Story4308

@KedoKudo KedoKudo self-assigned this Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (2fb979b) to head (31ef8b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #297      +/-   ##
==========================================
+ Coverage   94.58%   94.62%   +0.04%     
==========================================
  Files          21       21              
  Lines        1255     1266      +11     
==========================================
+ Hits         1187     1198      +11     
  Misses         68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look reasonable

@KedoKudo KedoKudo merged commit bdd1581 into next Mar 8, 2024
8 checks passed
@KedoKudo KedoKudo deleted the log_to_file branch March 8, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants