Skip to content

Commit

Permalink
Merge pull request #103 from orobix/feature/torch-upgrade
Browse files Browse the repository at this point in the history
Feature/torch upgrade
  • Loading branch information
lorenzomammana authored Feb 9, 2024
2 parents f856563 + bd73910 commit 45c2da2
Show file tree
Hide file tree
Showing 37 changed files with 707 additions and 703 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install Dependencies
run: |
python -m pip install -U pip poetry
python -m poetry install --no-cache -E docs
python -m poetry install --no-cache --with docs
- name: Determine Version
id: determine_version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Install Package
run: |
python -m pip install -U pip poetry
python -m poetry install --no-cache -E test -E onnx
python -m poetry install --no-cache --with test -E onnx
- name: Run Tests
run: |
Expand Down
7 changes: 7 additions & 0 deletions BREAKING_CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
# Breaking Changes
All the breaking changes will be documented in this file.

### [2.0.0]

#### Changed

- Quadra 2.0.0 works with torch 2 and pytorch lightning 2, lightning trainer configurations must be aligned following the [migration guide](https://lightning.ai/docs/pytorch/LTS/upgrade/migration_guide.html).
- Quadra now relies on CUDA 12 to work instead of the old CUDA 11.6

### [1.5.0]

#### Changed
Expand Down
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,18 @@
# Changelog
All notable changes to this project will be documented in this file.

### [2.0.0]

#### Updated

- Update torch to 2.1.2 with CUDA 12 support
- Update pytorch lightning to 2.1.*

#### Changed

- Refactor hydra plugins to use optional dev groups intend of extras to avoid dragging local packages around in external installations
- Refactor extra dev dependencies to use poetry groups instead
- Improve trainer configs to avoid wrong overrides when calling different trainer overrides
### [1.5.8]

#### Fix
Expand Down
22 changes: 12 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,18 @@ source myenv/bin/activate
pip install --upgrade pip
```

3a. **Install the `quadra` package** with pip:
```shell
pip install git+https://github.com/orobix/quadra.git
```
3. Install the package

3b. **Install the `quadra` package** with poetry:
```shell
pip install poetry
poetry add git+https://github.com/orobix/quadra.git
```
* **Install the `quadra` package** with pip:
```shell
pip install git+https://github.com/orobix/quadra.git
```

* **Install the `quadra` package** with poetry:
```shell
pip install poetry
poetry add git+https://github.com/orobix/quadra.git
```

4. **Run from CLI**:
Run the following command to check if the installation was successful:
Expand Down Expand Up @@ -243,7 +245,7 @@ First clone the repository from Github
First clone the repository from `Github`, then we need to install the package with optional dependencies (generally in editable mode) and enable the pre-commit hooks.

1. `git clone https://github.com/orobix/quadra.git && cd quadra`
1. Install `quadra` package in editable mode `poetry install -E dev -E docs -E test`
1. Install `quadra` package in editable mode `poetry install --with test,dev,docs --all-extras`
2. Install pre-commit hooks `pre-commit install`
3. (Optional) Eventually build documentation by calling required commands (see below).

Expand Down
6 changes: 3 additions & 3 deletions docs/tutorials/contribution.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ After setting up your environment you can install `Quadra` Library in different

!!!info

- `poetry install -E dev` (for development)
- `poetry install -E docs` (for documentation)
- `poetry install -E test` (for testing)
- `poetry install --with dev` (for development)
- `poetry install --with docs` (for documentation)
- `poetry install --with test` (for testing)


## Pre-commit Hooks
Expand Down
1 change: 0 additions & 1 deletion docs/tutorials/devices_setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ devices: [0]
accelerator: gpu
min_epochs: 1
max_epochs: 10
resume_from_checkpoint: null
log_every_n_steps: 10
```
Expand Down
Loading

0 comments on commit 45c2da2

Please sign in to comment.