Fix: improve device id #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orottier
reviewed
Sep 13, 2023
src/media_devices/mod.rs
Outdated
| num_channels: u16, | ||
| index: u8, | ||
| ) -> String { | ||
| let mut hasher = FxHasher::default(); |
There was a problem hiding this comment.
Instead of manually hashing it is probably best to include a private struct with DeviceInfo and derive Hash on it
orottier
reviewed
Sep 13, 2023
.pre-commit-config.yaml
Outdated
| @@ -64,7 +64,7 @@ repos: | |||
| --locked, | |||
| --workspace, | |||
| --features, | |||
| cubeb, | |||
| cpal, | |||
There was a problem hiding this comment.
This should probably be reverted and investigated separately
There was a problem hiding this comment.
The problem is that I was even not able to make a commit, because the pre-commit hook was crashing
orottier
approved these changes
Sep 13, 2023
|
Thanks for the work! |
|
Ok cool, I'll let you know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #356
Note that I had to modify the pre-commit hook because for some reason cubeb build w/ CMake through clippy was failing, weird thing is that if I ran an example with the cubeb feature that was working...