Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ChannelConfig.clone by changing AudioRenderQuantum.add args #364

Closed
wants to merge 1 commit into from

Conversation

orottier
Copy link
Owner

No description provided.

@orottier
Copy link
Owner Author

/bench

@github-actions
Copy link

Benchmark result:


bench_ctor
  Instructions:             4570561 (+0.248001%)
  L1 Accesses:              6827438 (+0.276724%)
  L2 Accesses:                54326 (-0.011043%)
  RAM Accesses:               61554 (-0.001625%)
  Estimated Cycles:         9253458 (+0.203320%)

bench_sine
  Instructions:            71168844 (+0.152669%)
  L1 Accesses:            103813463 (+0.142164%)
  L2 Accesses:               260318 (-1.925932%)
  RAM Accesses:               62425 (-0.004806%)
  Estimated Cycles:       107299928 (+0.113559%)

bench_sine_gain
  Instructions:            76311323 (+0.201343%)
  L1 Accesses:            111550644 (+0.179219%)
  L2 Accesses:               267825 (-0.442725%)
  RAM Accesses:               62529 (No change)
  Estimated Cycles:       115078284 (+0.168523%)

bench_sine_gain_delay
  Instructions:           151491028 (+0.135967%)
  L1 Accesses:            214319982 (+0.132701%)
  L2 Accesses:               528842 (-6.543057%)
  RAM Accesses:               64139 (-0.007795%)
  Estimated Cycles:       219209057 (+0.045058%)

bench_buffer_src
  Instructions:            17748834 (+0.617218%)
  L1 Accesses:             25755263 (+0.557404%)
  L2 Accesses:                86895 (-0.060956%)
  RAM Accesses:              100733 (+0.015886%)
  Estimated Cycles:        29715393 (+0.483763%)

bench_buffer_src_delay
  Instructions:            91647863 (+0.225560%)
  L1 Accesses:            126774221 (+0.210437%)
  L2 Accesses:               162872 (+0.094027%)
  RAM Accesses:              100887 (+0.007930%)
  Estimated Cycles:       131119626 (+0.204249%)

bench_buffer_src_iir
  Instructions:            42224491 (+1.000714%)
  L1 Accesses:             60939685 (+0.195501%)
  L2 Accesses:                87573 (+0.471536%)
  RAM Accesses:              100832 (+0.025792%)
  Estimated Cycles:        64906670 (+0.188115%)

bench_buffer_src_biquad
  Instructions:            38115363 (+0.702280%)
  L1 Accesses:             53513731 (+0.728959%)
  L2 Accesses:               118413 (+2.075773%)
  RAM Accesses:              100962 (+0.008915%)
  Estimated Cycles:        57639466 (+0.698159%)

bench_stereo_positional
  Instructions:            46327587 (+1.520454%)
  L1 Accesses:             69141591 (+1.654259%)
  L2 Accesses:               247777 (-6.558836%)
  RAM Accesses:              101046 (+0.022767%)
  Estimated Cycles:        73917086 (+1.425687%)

bench_stereo_panning_automation
  Instructions:            32722736 (+1.530270%)
  L1 Accesses:             49024214 (+1.866922%)
  L2 Accesses:               136371 (-0.104019%)
  RAM Accesses:              100841 (+0.009918%)
  Estimated Cycles:        53235504 (+1.716001%)

bench_analyser_node
  Instructions:            39902972 (+0.292770%)
  L1 Accesses:             55814958 (+0.243489%)
  L2 Accesses:               181266 (-0.106360%)
  RAM Accesses:              101382 (+0.020718%)
  Estimated Cycles:        60269658 (+0.225068%)


@orottier
Copy link
Owner Author

Interesting, I guess the compiler is smarter than me.
I'm working on a rewrite of the ChannelConfig and this was something I though could be made faster. Ah well

@orottier orottier closed this Sep 26, 2023
@orottier orottier deleted the feature/prevent-channel-config-clone branch September 26, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant