Fix AudioBufferSourceNode stitching
#531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r zone, cf. buffer stitching wpt test make start time sticky to sample time when inside floating point error zone cf. buffer stitching from wpt
…xtrapolate sample after end of buffer in certain conditions
|
Okay cool. Looks like good improvements. I'm a bit worried about performance regression due to extra loops, float accuracy etc but this seems all slow-track stuff anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some other wpt test (which were quite tricky)
Results for
the-audiobuffersourcenode-interface:Before
After (edit: better with the actual new results :)
I added a new dependency to test for floating point computation errors, I didn't feel like implementing this myself :)
I think it is ok as this could help us in other part of the code where we test against absolute values which is not very clean, let me know what you think!
I tried to comment the code but let me know if something is not clear, or doesn't feel right to you