-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unused regex colour var, and fix bug where mypy returned no errors #17
Conversation
✅ Deploy Preview for mypy-baseline ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Would you have time to add a test case for the issue you're fixing, please? We don't want the bug to have a regression. |
Apolgies for the slow reply - been very busy with work. Yes sure thing, will fix the failure and get a test written this weekend. Thanks again for the very useful library! |
Sorry, finally got around to adding a test etc. I also have an |
Thank you!
I like it! Bring it in as a new PR 👍🏿 |
This PR fixes :
msg
var as the following line callsself.message
, rather than I assumed the intendedmsg
invalid baseline, cannot parse line
This is with mypy
1.3.0
.