Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused regex colour var, and fix bug where mypy returned no errors #17

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

cfculhane
Copy link
Contributor

This PR fixes :

  • unused msg var as the following line calls self.message, rather than I assumed the intended msg
  • The case where mypy has no errors and all fixes are synced, mypy-baseline exits with invalid baseline, cannot parse line

This is with mypy 1.3.0 .

@netlify
Copy link

netlify bot commented May 28, 2023

Deploy Preview for mypy-baseline ready!

Name Link
🔨 Latest commit 219fe40
🔍 Latest deploy log https://app.netlify.com/sites/mypy-baseline/deploys/651119313080ed00084fa0dc
😎 Deploy Preview https://deploy-preview-17--mypy-baseline.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@orsinium
Copy link
Member

Would you have time to add a test case for the issue you're fixing, please? We don't want the bug to have a regression.

@cfculhane
Copy link
Contributor Author

Apolgies for the slow reply - been very busy with work. Yes sure thing, will fix the failure and get a test written this weekend. Thanks again for the very useful library!

@cfculhane
Copy link
Contributor Author

cfculhane commented Sep 25, 2023

Sorry, finally got around to adding a test etc. I also have an --ignore-categories commit on my fork that you might like too, I find it quite useful to ignore note lines, its fully ready to go with a test etc.

@orsinium
Copy link
Member

Thank you!

I also have an --ignore-categories commit on my fork that you might like too

I like it! Bring it in as a new PR 👍🏿

.gitignore Show resolved Hide resolved
@orsinium orsinium merged commit 4b1e5fe into orsinium-labs:master Sep 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants