Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is EPL 2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eclipse public license https://en.wikipedia.org/wiki/Eclipse_Public_License
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From wikipedia:
I am not an expert in licenses, but to me, it seems similar to the LGPL licenses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, it does have copyleft though. Is there an alternative library? I couldn't find EPL-2.0, only EPL-1.0 on tldr legal :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ory/docs/actions/runs/8830787071/job/24244662059?pr=1686#step:5:52
It's not a library we're referencing, but mermaid is: https://github.com/ory/docs/blob/jonas-jonas/updateDocusaurus/package-lock.json#L17967-L17993
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mermaid-js/mermaid#5043 okay seems like this is an issue, and we're gonna be stuck on specific mermaid versions.
I do think for docs, it would be fine to allow EPL, but for the Ory Network not. I'll try to find a mermaid version that passes license checks first.