Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docusaurus to 3.X #1686

Merged
merged 27 commits into from
Jun 26, 2024
Merged

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas

This comment was marked as outdated.

Copy link

argos-ci bot commented May 2, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Waiting for the first build to start…

vinckr
vinckr previously approved these changes Jun 21, 2024
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)
looked through most pages

@aeneasr
Copy link
Member

aeneasr commented Jun 25, 2024

I didn't look at the 60k lines changed but browsed a few pages and they look good to me. Did you check that there are no page speed or SEO issues?

@jonas-jonas
Copy link
Member Author

@aeneasr most of that is package-lock.json:

image

Performance is a little worse on the preview env, but that might be due to it being a preview env, SEO is 100%.

@aeneasr
Copy link
Member

aeneasr commented Jun 25, 2024

Yeah, preview env is always a bit slower

aeneasr
aeneasr previously approved these changes Jun 25, 2024
@jonas-jonas jonas-jonas merged commit 6855fc5 into master Jun 26, 2024
9 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/updateDocusaurus branch June 26, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants