-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revoke refresh token on request only #766
base: master
Are you sure you want to change the base?
feat: revoke refresh token on request only #766
Conversation
@aeneasr Do you mind taking a look at this? It's a fairly simple change and has no compatibility impact. |
Sorry, I lack the time to look into PRs in fosite at the moment. This looks good to me, but it would be even better if there was a small test for this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but yes, tests please.
Thanks! |
The OAuth 2.0 Token Revocation specification (RFC7009)
indicates that the authorization server can choose to only revoke refresh tokens if the token in the request is a
refresh token in the authorization grant.
This change gives an option to not revoke the refresh token if the token in the request is an access token.
Related Issue or Design Document
N/A
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments
N/A