Skip to content

Commit

Permalink
fix: remove earliest_possible_extend default in schema (#3464)
Browse files Browse the repository at this point in the history
  • Loading branch information
jonas-jonas authored Aug 29, 2023
1 parent 5c17c38 commit 7e05b7d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion embedx/config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2656,7 +2656,6 @@
"description": "Sets when a session can be extended. Settings this value to `24h` will prevent the session from being extended before until 24 hours before it expires. This setting prevents excessive writes to the database. We highly recommend setting this value.",
"type": "string",
"pattern": "^([0-9]+(ns|us|ms|s|m|h))+$",
"default": "24h",
"examples": [
"1h",
"1m",
Expand Down
3 changes: 2 additions & 1 deletion session/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1008,8 +1008,9 @@ func TestHandlerRefreshSessionBySessionID(t *testing.T) {
require.NoError(t, err)
require.Equal(t, http.StatusOK, res.StatusCode)

s, err = reg.SessionPersister().GetSession(context.Background(), s.ID, ExpandNothing)
updatedSession, err := reg.SessionPersister().GetSession(context.Background(), s.ID, ExpandNothing)
require.Nil(t, err)
require.True(t, s.ExpiresAt.Before(updatedSession.ExpiresAt))
})

t.Run("case=should return 400 when bad UUID is sent", func(t *testing.T) {
Expand Down

0 comments on commit 7e05b7d

Please sign in to comment.