-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: transmit current session ID to Hydra when accepting the login #3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3426 +/- ##
==========================================
+ Coverage 77.97% 77.99% +0.01%
==========================================
Files 327 327
Lines 21558 21591 +33
==========================================
+ Hits 16810 16839 +29
- Misses 3491 3496 +5
+ Partials 1257 1256 -1
|
hperl
force-pushed
the
hperl/accept-login-add-session-id
branch
2 times, most recently
from
August 15, 2023 07:31
ad9ca19
to
54599e5
Compare
hperl
force-pushed
the
hperl/accept-login-add-session-id
branch
from
August 15, 2023 08:48
54599e5
to
b742def
Compare
aeneasr
previously approved these changes
Aug 15, 2023
hperl
force-pushed
the
hperl/accept-login-add-session-id
branch
4 times, most recently
from
August 16, 2023 11:18
96b5975
to
6525867
Compare
alnr
previously approved these changes
Aug 16, 2023
aeneasr
previously approved these changes
Aug 16, 2023
hperl
force-pushed
the
hperl/accept-login-add-session-id
branch
from
August 17, 2023 06:36
43c43f8
to
7b81415
Compare
hperl
force-pushed
the
hperl/accept-login-add-session-id
branch
from
August 17, 2023 07:20
7b81415
to
fc27095
Compare
hperl
force-pushed
the
hperl/accept-login-add-session-id
branch
from
August 17, 2023 07:47
fc27095
to
b92481f
Compare
aeneasr
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked on ory/hydra#3596, because the Hydra client needs to be updated.Part of https://github.com/ory-corp/cloud/issues/5038
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments