Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transmit current session ID to Hydra when accepting the login #3426

Merged
merged 10 commits into from
Aug 17, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Aug 10, 2023

This PR is blocked on ory/hydra#3596, because the Hydra client needs to be updated.

Part of https://github.com/ory-corp/cloud/issues/5038

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested review from aeneasr, alnr and jonas-jonas August 10, 2023 11:15
@hperl hperl self-assigned this Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #3426 (2546daa) into master (1429949) will increase coverage by 0.01%.
The diff coverage is 77.77%.

❗ Current head 2546daa differs from pull request most recent head 2d5b264. Consider uploading reports for the commit 2d5b264 to get more accurate results

@@            Coverage Diff             @@
##           master    #3426      +/-   ##
==========================================
+ Coverage   77.97%   77.99%   +0.01%     
==========================================
  Files         327      327              
  Lines       21558    21591      +33     
==========================================
+ Hits        16810    16839      +29     
- Misses       3491     3496       +5     
+ Partials     1257     1256       -1     
Files Changed Coverage Δ
selfservice/flow/verification/handler.go 55.14% <0.00%> (-2.55%) ⬇️
hydra/fake.go 72.72% <40.00%> (-7.28%) ⬇️
hydra/hydra.go 63.41% <100.00%> (+0.45%) ⬆️
selfservice/flow/login/handler.go 81.19% <100.00%> (+0.49%) ⬆️
selfservice/flow/login/hook.go 87.74% <100.00%> (+1.02%) ⬆️
selfservice/flow/registration/hook.go 72.97% <100.00%> (+1.14%) ⬆️

... and 1 file with indirect coverage changes

@hperl hperl force-pushed the hperl/accept-login-add-session-id branch 2 times, most recently from ad9ca19 to 54599e5 Compare August 15, 2023 07:31
@hperl hperl marked this pull request as ready for review August 15, 2023 07:32
@hperl hperl requested a review from zepatrik as a code owner August 15, 2023 07:32
@hperl hperl force-pushed the hperl/accept-login-add-session-id branch from 54599e5 to b742def Compare August 15, 2023 08:48
aeneasr
aeneasr previously approved these changes Aug 15, 2023
@hperl hperl force-pushed the hperl/accept-login-add-session-id branch 4 times, most recently from 96b5975 to 6525867 Compare August 16, 2023 11:18
alnr
alnr previously approved these changes Aug 16, 2023
aeneasr
aeneasr previously approved these changes Aug 16, 2023
@hperl hperl dismissed stale reviews from aeneasr and alnr via e2d9362 August 16, 2023 19:01
@hperl hperl force-pushed the hperl/accept-login-add-session-id branch from 43c43f8 to 7b81415 Compare August 17, 2023 06:36
@hperl hperl force-pushed the hperl/accept-login-add-session-id branch from 7b81415 to fc27095 Compare August 17, 2023 07:20
@hperl hperl force-pushed the hperl/accept-login-add-session-id branch from fc27095 to b92481f Compare August 17, 2023 07:47
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hperl hperl merged commit 610c76d into master Aug 17, 2023
@hperl hperl deleted the hperl/accept-login-add-session-id branch August 17, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants