Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove earliest_possible_extend default in schema #3464

Merged
merged 1 commit into from
Aug 29, 2023
Merged

chore: remove earliest_possible_extend default in schema #3464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion embedx/config.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2656,7 +2656,6 @@
"description": "Sets when a session can be extended. Settings this value to `24h` will prevent the session from being extended before until 24 hours before it expires. This setting prevents excessive writes to the database. We highly recommend setting this value.",
"type": "string",
"pattern": "^([0-9]+(ns|us|ms|s|m|h))+$",
"default": "24h",
"examples": [
"1h",
"1m",
Expand Down
3 changes: 2 additions & 1 deletion session/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,8 +1008,9 @@ func TestHandlerRefreshSessionBySessionID(t *testing.T) {
require.NoError(t, err)
require.Equal(t, http.StatusOK, res.StatusCode)

s, err = reg.SessionPersister().GetSession(context.Background(), s.ID, ExpandNothing)
updatedSession, err := reg.SessionPersister().GetSession(context.Background(), s.ID, ExpandNothing)
require.Nil(t, err)
require.True(t, s.ExpiresAt.Before(updatedSession.ExpiresAt))
})

t.Run("case=should return 400 when bad UUID is sent", func(t *testing.T) {
Expand Down
Loading