fix: registration code ui nodes group #3505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registration with code method incorrectly returns UI nodes for traits on group
code
. When only thecode
method is enabled, this wouldn't cause a problem in the UI, however, with multiple methods enabled which per default use thedefault
group to map methods to the UI, this becomes a problem, since the UI would map duplicate nodes.Although this could be changed in the UI consuming the API and would not cause any data submit problems, Kratos should rather stay consistent with using the
default
group with traits on login and registration flows.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments