-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify perl linting rules #5348
base: master
Are you sure you want to change the base?
Unify perl linting rules #5348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5348 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 389 389
Lines 37319 37319
=======================================
Hits 36693 36693
Misses 626 626 ☔ View full report in Codecov by Sentry. |
8811a7a
to
5b1d054
Compare
-fbl # don't change blank lines | ||
-fnl # don't remove new lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree to include this line but I do not want to loosen the line-length rule. We must find a way to support project specific rule additions and exceptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I remember the conversation from the other PR there's no easy way to add exceptions per project. Could 120 be used instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already covered that we can not easily reduce os-autoinst-distri-opensuse from 160 down to 120
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I guess I'm fine with 160 then if it's the only deviation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can live with a .perltidyrc per project. If the common project has a config, existing and new projects can use this by symlinking, but they don't have to, so openQA would keep its own config, if the common project uses 160, or if the common project uses 120, distri-opensuse would use its own.
That's at least what @josegomezr agreed on when we chatted today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
This pull request is now in conflicts. Could you fix it? 🙏 |
Testing the perltidy config from os-autoinst/os-autoinst-common#30