Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling hook script multiple times #6068

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Martchus
Copy link
Contributor

  • Call the hook script only if the job was not already in state DONE.
  • Note that the "done" function might be called multiple times, e.g. by the worker and also by the stale job detection.
  • There is still a small possibility that the hook script is called multiple times but it is hopefully not relevant in practice.
  • See https://progress.opensuse.org/issues/169747

* Call the hook script only if the job was not already in state `DONE`.
* Note that the "done" function might be called multiple times, e.g. by the
  worker and also by the stale job detection.
* There is still a small possibility that the hook script is called
  multiple times but it is hopefully not relevant in practice.
* See https://progress.opensuse.org/issues/169747
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (d360bdf) to head (d7e0ff6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6068   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         395      395           
  Lines       39492    39508   +16     
=======================================
+ Hits        39092    39108   +16     
  Misses        400      400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mergify mergify bot merged commit ebc60b4 into os-autoinst:master Nov 25, 2024
46 checks passed
@Martchus Martchus deleted the hook-script-multi-call branch November 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants