Prevent SIGCHLD handler override within tests #6090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent _setup_sigchld_handler overriding the handler for IPC::Run3 inside AssetPack. Without this, the sass process is not handled correctly inside the tests and the assets are not correctly compiled by the AssetPack. Reference: https://progress.opensuse.org/issues/174607
perlpunk
approved these changes
Dec 20, 2024
Martchus
approved these changes
Dec 21, 2024
|
codecov report missing, merging manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent _setup_sigchld_handler overriding the handler for IPC::Run3 inside AssetPack. Without this, the sass process is not handled correctly inside the tests and the assets are not correctly compiled by the AssetPack.
Reference: https://progress.opensuse.org/issues/174607