Linting & Improved workflows

- Improved isotovideo example workflow, it can be easily extended
  with a matrix as per GitHub Actions docs [0].

  It brings:
  - A perl script for checking the test results, to remove `jq`
    usages.
  - Pipeline Artifacts, it's possible to inspect the test
    results after a run.

  And now the example workflow is green and not repeated.

- Added `use warnings` to perl scripts as per good practices.

Co-authored-by: Tina Müller <[email protected]>

[0]: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#example-expanding-configurations

.github/workflows/commit-message-checker.yml

@@ -0,0 +1,15 @@
+---
+name: 'Commit message check'
+
+on:
+  pull_request:
+  push:
+    branches:
+      # we must not fix commit messages when they already reached main
+      - '!main'
+
+jobs:
+  check-commit-message:
+    secrets:
+      accessToken: "${{ secrets.GITHUB_TOKEN }}"
+    uses: os-autoinst/os-autoinst-common/.github/workflows/base-commit-message-checker.yml@master

.github/workflows/isotovideo.yml

@@ -1,11 +1,48 @@
 ---
 name: isotovideo
 # yamllint disable-line rule:truthy
-on: [push, pull_request]
+on:
+  - pull_request
 jobs:
-  test:
-    runs-on: ubuntu-latest
+  isotovideo:
+    strategy:
+      matrix:
+        # An example matrix, it'll create a derivate job for each 
+        # item specified here. For simplicity sake the example below
+        # has the full var line since it's easy enough.
+        #
+        # For more complex setups it'll be worth exploring advance matrix setups
+        # see: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#example-expanding-configurations
+        isotovideo-args:
+          - "qemu_no_kvm=1 casedir=."
+    runs-on: ubuntu-20.04
     steps:
-      - uses: actions/checkout@v2
-      - name: Run isotovideo against test code in happy-path scenario
-        run: podman run --rm -it -v .:/tests:Z registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86 qemu_no_kvm=1 casedir=/tests
+      - uses: actions/checkout@v4
+
+      - name: Run isotovideo against test code
+        uses: "docker://registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86"
+        with:
+          args: ${{ matrix.isotovideo-args }} ${{ env.ACTIONS_STEP_DEBUG && '--debug' || '' }}
+          entrypoint: 'isotovideo'
+
+      - name: Validate test results
+        uses: "docker://registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86"
+        with:
+          args: ./testresults/
+          entrypoint: "./scripts/validate-test-results"
+
+      - name: Archive test artifcats
+        if: always()
+        uses: actions/upload-artifact@v3
+        with:
+          name: isotovideo-artifacts
+          path: |
+            ./testresults/
+            ./video.ogv
+            ./video_time.vtt
+            ./qemu_state.json
+            ./serial_terminal.txt
+            ./virtio_console.log
+            ./virtio_console1.log
+            ./virtio_console_user.log
+          retention-days: 7

main.pm

@@ -2,6 +2,8 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
 use strict;
+use warnings;
+
 use testapi;
 use autotest;
 

scripts/validate-test-results

@@ -0,0 +1,28 @@
+#!/usr/bin/env perl
+
+# Copyright 2023 SUSE LLC
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+use strict;
+use warnings;
+use experimental 'signatures';
+
+use Mojo::JSON qw(decode_json);
+use Mojo::Path;
+use Mojo::File qw(path);
+use Test::More;
+
+sub validate_test_result($result_file_path) {
+    my $result_file = path(Mojo::Path->new($result_file_path)->canonicalize);
+    my $test_result = decode_json($result_file->slurp)->{result};
+    return is $test_result, 'ok', sprintf ('Test result [%s] ok', $result_file->to_string);
+}
+
+my ($dir) = @ARGV;
+
+print "Missing argument DIR\n" and exit 1 unless $dir;
+
+my @results = glob("$dir/result-*.json");
+validate_test_result($_) for (@results);
+
+done_testing;

testresult/result-a-test.json

@@ -0,0 +1,3 @@
+{
+	"result": "ok"
+}

tests/boot.pm

@@ -1,8 +1,10 @@
 # Copyright 2014-2018 SUSE LLC
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-use base 'basetest';
 use strict;
+use warnings;
+
+use base 'basetest';
 use testapi;
 
 sub run {