Skip to content

Commit

Permalink
t: Use consistent 'Mojo::Base' instead of strict+warnings
Browse files Browse the repository at this point in the history
Same as suggested in our documentation we should use Mojo::Base
consistently in all openQA test modules.
  • Loading branch information
okurz committed Dec 20, 2023
1 parent 3ad4012 commit 73c6fdf
Show file tree
Hide file tree
Showing 12 changed files with 10 additions and 22 deletions.
1 change: 0 additions & 1 deletion lib/utils.pm
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package utils;

use Mojo::Base 'Exporter', -signatures;
use Exporter;
use strict;
use testapi;
use File::Basename qw(basename);

Expand Down
3 changes: 1 addition & 2 deletions tests/containers/build.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use strict;
use base 'openQAcoretest';
use Mojo::Base 'openQAcoretest';
use testapi;

sub run {
Expand Down
3 changes: 1 addition & 2 deletions tests/install/boot.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use strict;
use base 'openQAcoretest';
use Mojo::Base 'openQAcoretest';
use utils;

sub run {
Expand Down
3 changes: 1 addition & 2 deletions tests/install/openqa_webui.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use strict;
use base 'openQAcoretest';
use Mojo::Base 'openQAcoretest';
use testapi;
use utils;

Expand Down
3 changes: 1 addition & 2 deletions tests/install/openqa_worker.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use strict;
use base 'openQAcoretest';
use Mojo::Base 'openQAcoretest';
use testapi;
use utils;

Expand Down
3 changes: 1 addition & 2 deletions tests/install/test_distribution.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use strict;
use base 'openQAcoretest';
use Mojo::Base 'openQAcoretest';
use testapi;
use utils;

Expand Down
3 changes: 1 addition & 2 deletions tests/openQA/dashboard.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use strict;
use base 'openQAcoretest';
use Mojo::Base 'openQAcoretest';
use testapi;
use utils;

Expand Down
3 changes: 1 addition & 2 deletions tests/openQA/login.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use strict;
use base 'openQAcoretest';
use Mojo::Base 'openQAcoretest';
use testapi;

sub run {
Expand Down
3 changes: 1 addition & 2 deletions tests/osautoinst/start_test.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use strict;
use base 'openQAcoretest';
use Mojo::Base 'openQAcoretest';
use testapi;
use utils;

Expand Down
1 change: 0 additions & 1 deletion tests/osautoinst/test_running.pm
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use strict;
use Mojo::Base 'openQAcoretest', -signatures;
use testapi;
use utils;
Expand Down
3 changes: 1 addition & 2 deletions tests/osautoinst/worker.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use strict;
use base 'openQAcoretest';
use Mojo::Base 'openQAcoretest';
use testapi;
use utils qw(wait_for_desktop switch_to_root_console clear_root_console);

Expand Down
3 changes: 1 addition & 2 deletions tests/shutdown/shutdown.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use strict;
use base 'openQAcoretest';
use Mojo::Base 'openQAcoretest';
use testapi;
use utils qw(switch_to_root_console);

Expand Down

0 comments on commit 73c6fdf

Please sign in to comment.