Enable JeOS-for-kvm-and-xen-sdboot flavor #20804
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
rbmarliere
requested review from
mloviska and
ricardobranco777
as code owners
tests/jeos/firstrun.pm
Outdated
| @@ -93,7 +93,7 @@ sub verify_norepos { | |||
| sub verify_bsc { | |||
| if (is_qemu && is_x86_64 && script_run("rpm -q qemu-guest-agent") != 0) { | |||
| # Included in SLE-15-SP2+, TW and Leap | |||
| die("bsc#1207135 - Missing qemu-guest-agent from virtual images") unless is_sle('<15-SP2'); | |||
| die("bsc#1207135 - Missing qemu-guest-agent from virtual images") unless is_sle('<15-SP2') || is_bootloader_sdboot; | |||
There was a problem hiding this comment.
How is this related to systemd boot? If the package is in other TW images, aren't we covering a bug?
There was a problem hiding this comment.
Thanks for pointing that out. I wasn't sure about this one, but the fact is that qemu-guest-agent does not come installed in the JeOS-for-kvm-and-xen-sdboot image. The sub verify_bsc is only ran if is_jeos, so I thought adding that unless wouldn't be harmful. Please advise :)
There was a problem hiding this comment.
I would go for a bug report as the qemu-ga is recommended to be used in any qemu VM.
There was a problem hiding this comment.
Will do! As for this PR, I removed the change in fa5412f
There was a problem hiding this comment.
Some tests scheduled for JeOS don't make sense to have under the new sdboot (systemd-boot) flavor JeOS-for-kvm-and-xen-sdboot. Signed-off-by: Ricardo B. Marliere <[email protected]>
The new flavor JeOS-for-kvm-and-xen-sdboot (systemd-boot) should simply match the bootloader screen and return. Signed-off-by: Ricardo B. Marliere <[email protected]>
This PR contains some small fixes required to run the new Tumbleweed JeOS-for-kvm-and-xen-sdboot flavor.