Replace spurt with Mojo::File::spew #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipeline shows a warning on xt/01-make-update-deps.t for deprecate use of Mojo::File::spurt. Fix it replacing with Mojo::File::spew Signed-off-by: ybonatakis <[email protected]>
perlpunk
requested changes
Jan 18, 2024
There was a problem hiding this comment.
For changes under external/ please always change in the corresponding git subrepo first:
https://github.com/os-autoinst/os-autoinst-common
And then pull the changes in with git subrepo pull.
We should do a pull right now anyway, there have been changes.
okurz
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Files in external/ should not be changed here but in https://github.com/os-autoinst/os-autoinst-common and then updated using git-subrepo. We might already have those changes prepared but not updated yet
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline shows a warning on xt/01-make-update-deps.t for deprecate use of Mojo::File::spurt. Fix it replacing with Mojo::File::spew