Add devel package for linters #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b10n1k
reviewed
Jan 25, 2024
baierjan
approved these changes
Jan 25, 2024
perlpunk
commented
Jan 25, 2024
Comment on lines
+41
to
+45
| %package devel | ||
| Summary: Development package for os-autoinst-scripts-deps | ||
| Group: Development/Tools/Other | ||
| Requires: %devel_requires | ||
|
|
There was a problem hiding this comment.
I'm not sure if this enough to create a new package in OBS
There was a problem hiding this comment.
Good point. I believe so. This should create a new subpackage, like in openQA, but you are likely missing a %description and %files sections.
There was a problem hiding this comment.
ah right, the description.
I added both now. %files is just empty, but it's probably needed.
There was a problem hiding this comment.
yes, an empty section is needed. Current version looks good now
baierjan
requested changes
Jan 25, 2024
Comment on lines
+41
to
+45
| %package devel | ||
| Summary: Development package for os-autoinst-scripts-deps | ||
| Group: Development/Tools/Other | ||
| Requires: %devel_requires | ||
|
|
There was a problem hiding this comment.
Good point. I believe so. This should create a new subpackage, like in openQA, but you are likely missing a %description and %files sections.
okurz
approved these changes
Jan 25, 2024
baierjan
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: https://progress.opensuse.org/issues/153793