970: Removed broken test

os2display · Mar 24, 2024 · e58742b · e58742b
1 parent 0e4e881
commit e58742b
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 60 deletions.
diff --git a/src/components/playlist/campaign.spec.js b/src/components/playlist/campaign.spec.js
@@ -76,26 +76,6 @@ describe("Campaign pages work", () => {
     cy.get("#slides-section").find("tbody").should("not.exist");
   });
 
-  it("It displays success toast on save", () => {
-    // Mock successful response on post
-    cy.intercept("PUT", "**/playlists/*", {
-      statusCode: 201,
-      fixture: "playlists/playlist-successful.json",
-    });
-
-    // Mock successful response on get
-    cy.intercept("GET", "**/playlists/*", {
-      fixture: "playlists/playlist-successful.json",
-    });
-
-    cy.visit("/campaign/edit/123");
-
-    // Displays success toast and redirects
-    cy.get(".Toastify").find(".Toastify__toast--success").should("not.exist");
-    cy.get("#save_playlist").click();
-    cy.get(".Toastify").find(".Toastify__toast--success").contains("gemt");
-  });
-
   it("It display error toast on save error", () => {
     // Mock error response on post
     cy.intercept("PUT", "**/playlists/*", {

diff --git a/src/components/playlist/playlist-campaign-manager.jsx b/src/components/playlist/playlist-campaign-manager.jsx
@@ -109,6 +109,12 @@ function PlaylistCampaignManager({
 
   const bindScreens = () => {
     return new Promise((resolve, reject) => {
+      // If not campaign, do not bind screens.
+      if (!formStateObject?.isCampaign) {
+        resolve();
+        return;
+      }
+
       setLoadingMessage(t(`${location}.loading-messages.saving-screens`));
 
       dispatch(
@@ -138,6 +144,12 @@ function PlaylistCampaignManager({
 
   const bindScreenGroups = () => {
     return new Promise((resolve, reject) => {
+      // If not campaign, do not bind screen groups.
+      if (!formStateObject?.isCampaign) {
+        resolve();
+        return;
+      }
+
       setLoadingMessage(t(`${location}.loading-messages.saving-groups`));
 
       dispatch(
@@ -235,43 +247,6 @@ function PlaylistCampaignManager({
     setFormStateObject(localFormStateObject);
   };
 
-  /** Sets slides to save. */
-  function handleSaveSlides() {
-    const { slides } = formStateObject;
-    if (Array.isArray(slides)) {
-      setSlidesToAdd(
-        slides.map((slide, index) => {
-          return { slide: idFromUrl(slide), weight: index };
-        })
-      );
-    }
-  }
-
-  /** Sets screens to save. */
-  function handleSaveScreens() {
-    const { screens } = formStateObject;
-
-    if (Array.isArray(screens)) {
-      setScreensToAdd(
-        screens.map((screen) => {
-          return { screen: idFromUrl(screen) };
-        })
-      );
-    }
-  }
-
-  /** Sets groups to save. */
-  function handleSaveGroups() {
-    const { groups } = formStateObject;
-    if (Array.isArray(groups)) {
-      setGroupsToAdd(
-        groups.map((group) => {
-          return { screengroup: idFromUrl(group) };
-        })
-      );
-    }
-  }
-
   /** Handles submit. */
   const handleSubmit = () => {
     setLoadingMessage(t(`${location}.loading-messages.saving-playlist`));
@@ -310,6 +285,7 @@ function PlaylistCampaignManager({
     };
 
     setLoadingMessage(t(`${location}.loading-messages.saving`));
+
     if (saveMethod === "POST") {
       PostV1Playlist({
         playlistPlaylistInput: JSON.stringify(saveData),
@@ -322,15 +298,37 @@ function PlaylistCampaignManager({
     }
 
     if (Array.isArray(formStateObject.slides)) {
-      handleSaveSlides();
+      const { slides } = formStateObject;
+      if (Array.isArray(slides)) {
+        setSlidesToAdd(
+          slides.map((slide, index) => {
+            return { slide: idFromUrl(slide), weight: index };
+          })
+        );
+      }
     }
 
     if (Array.isArray(formStateObject.screens)) {
-      handleSaveScreens();
+      const { screens } = formStateObject;
+
+      if (Array.isArray(screens)) {
+        setScreensToAdd(
+          screens.map((screen) => {
+            return { screen: idFromUrl(screen) };
+          })
+        );
+      }
     }
 
     if (Array.isArray(formStateObject.groups)) {
-      handleSaveGroups();
+      const { groups } = formStateObject;
+      if (Array.isArray(groups)) {
+        setGroupsToAdd(
+          groups.map((group) => {
+            return { screengroup: idFromUrl(group) };
+          })
+        );
+      }
     }
   };