Feature/2826 create feed source UI #268
Conversation
…ing in FeedSourceManager
…edSourceForm props and templates
| setDynamicFormElement(null); | ||
| } | ||
| } | ||
| }, [formStateObject || null]); |
There was a problem hiding this comment.
you already have one useEffect for formStateObject...
src/translations/da/common.json
Outdated
| "load-feed-source-error": "Der skete en fejl da feed source med følgende id: {{id}} skulle hentes:" | ||
| }, | ||
| "dynamic-fields": { | ||
| "EventDatabaseApiFeedType": { |
There was a problem hiding this comment.
translation keys should be lower-case
| const NotifiedFeedTypeTemplate = ({ | ||
| handleInput, | ||
| formStateObject, | ||
| t, |
There was a problem hiding this comment.
no need to inject t through props...
const { t } = useTranslation("common", { keyPrefix: "notified-feed-type" });
| <FormInput | ||
| name="host" | ||
| type="text" | ||
| label={t("dynamic-fields.EventDatabaseApiFeedType.host")} |
There was a problem hiding this comment.
see comment above, this will allow you to do:
label={t("host")}
instead of all the dots
| const EventDatabaseApiTemplate = ({ | ||
| handleInput, | ||
| formStateObject, | ||
| t, |
There was a problem hiding this comment.
no need to inject t through props...
const { t } = useTranslation("common", { keyPrefix: "event-database-feed-type" });
| } | ||
| formStateObject.secrets = newSecrets; | ||
| } | ||
| }, [formStateObject]); |
There was a problem hiding this comment.
i think this code should only run if formStateObject.feedType changes. This should be achievable by something along the lines of:
useEffect(() => {
if (formStateObject?.feedType) {
... <update secrets>
}
}, [formStateObject.feedType]);
There was a problem hiding this comment.
I revised this part a bit, but since the formstateobject doesn't support nested keys, this useEffect needs to be called on formstateobject updates, to set e.g.
formStateObject.token
into
formStateObject.secrets.token
| if (formStateObject && formStateObject.feedType) { | ||
| let newSecrets = {}; | ||
|
|
||
| switch (formStateObject.feedType) { |
There was a problem hiding this comment.
I don't think I understand the purpose of this switch...
Adjustments
Link to ticket
2826
Description
This PR introduces a user interface for viewing, creating, updating and deleting feed sources.
Screenshot of the result
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.