Navbar + CMS Fetching #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
YB-BigSwan
commented
Aug 5, 2024
YB-BigSwan
commented
- Nav now properly fetches data from the CMS
- Nav links set according to text_en lowercase with spaces replaces with - (e.g. text_en = Nation Info : href="nation-info")
- Nav link classnames set dynamically because Next and TS don't allow the usage of activeClassName
- Initial nation info age setup
- Nav is not totally done, but making a PR so we can merge and stay up-to-date
added 7 commits
July 27, 2024 09:12
- this is just an initial commit - ran into a few possible issues while trying to fetch from CMS, just want to do a sanity check before going further
…s upset about comes directly from the docs and should be fine. Additionally addresses one linter warning for Navbar.tsx
- nav styling including active classes for active nav link styling - start of nation-info page - stopping for today due to CMS CORS issues
- Nav now properly fetches navlink text from cms - Nav link routes are set based on text_en lowercase, with whitespace replaced by - - Nav link classname dynamically set because Next and TS do not like activeClassName - Types added for CMS data
|
Visit the preview URL for this PR (updated for commit 5410051): https://satakuntalainenosakunta--pr13-next-site-tr3acsym.web.app (expires Mon, 12 Aug 2024 15:57:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1ec35f964edce5d08911a93688b4dc7a051b997f |
vuolen
reviewed
Aug 5, 2024
components/Navbar.tsx
Outdated
| const router = useRouter(); | ||
| const currentRoute = router.pathname; | ||
| const navGeneral = cmsData.data.slice(0, 4); | ||
| const navFormembers = cmsData.data.slice(4); |
There was a problem hiding this comment.
Good catch, both issues fixed. 👍
vuolen
reviewed
Aug 5, 2024
hooks/types.ts
Outdated
| @@ -0,0 +1,14 @@ | |||
| type CMSItem = { | |||
| id: number; | |||
| user_created: string; | |||
There was a problem hiding this comment.
I would argue that we should hide the item's metadata just in case. At least for the user IDs user_created and user_updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.