Refactor cards, styling changes, and page blocking #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
YB-BigSwan
commented
Aug 30, 2024
YB-BigSwan
commented
- Adds two new reusable components, HorizontalCard and VerticalCard.
- Removes lots of duplicate styling and moves them to globals.css.
- Updates styles to match the designs made by Saga.
…moves lots of duplicate styling and moves them to globals.css. Updates styles to match the designs make by Saga.
|
Visit the preview URL for this PR (updated for commit 26f2923): https://satakuntalainenosakunta--pr32-next-site-frg8e3b8.web.app (expires Mon, 09 Sep 2024 15:06:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1ec35f964edce5d08911a93688b4dc7a051b997f |
|
May need to update some of the card prop types in the future to work with the CMS WYSIWYG editor. At the moment they are all strings. |
…g so this hasn't been showing on my gh profile...
…cts from the new CMS collection 'Contact'. Updates cmsClient to add typing for CMS 'Contact'.
|
Will continue working on the harassment and board contact forms tomorrow. |
- Updates form component to have honeypots for bots - Updates validationSchema logic to fix bug where name and email were still required when wantsAnswer not selected - Adds logic to post to google form and give snackbar status messages on submit/submit attempts - Disables sumbit button and changes text to 'Sending' while form is sending to provide user with feedback and prevent duplicate messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.