Skip to content

Issue With session_destroy() And A Few Other Suggestions #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

A99US
Copy link

@A99US A99US commented Feb 17, 2022

Problem I :
Logout function run session_destroy(). Destroying all active session of the website.
Solution :
Change all phpMiniAdmin session variables into $_SESSION['pmAdmin'], so we can just use unset($_SESSION['pmAdmin']) instead of session_destroy(). So it doesn't destroy the whole website active session

Suggestion I :
Move phpminiconfig.php include line (from line 32 to line 53), so the config can override all previous variables above it
Adding few line in the config file for example ($authPage, default timezone, display_errors) if Suggestion I is accepted

Suggestion II :
Adding your own user privilege authenticator $authPage (if any). Instead of using $ACCESS_PWD as an authenticator, your ability to open phpMiniAdmin would be dictated by whether you're already login from the main website / main auth function or not.
Example :
$authPage = "session.php"; //Will include session.php if file exist

@A99US A99US marked this pull request as draft February 20, 2022 01:06
@A99US A99US marked this pull request as ready for review February 20, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant