Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bib: mount devtmpfs inside the container too #238

Merged
merged 2 commits into from
Mar 6, 2024
Merged

bib: mount devtmpfs inside the container too #238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d68e37
bib: mount `devtmpfs` inside the container too
mvo5 Mar 6, 2024
3673011
bib: tweak EnsureEnvironment() based on the feedback from Colin
mvo5 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions bib/internal/setup/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,20 @@ func EnsureEnvironment() error {
if err := util.RunCmdSync("chcon", installType, destPath); err != nil {
return err
}

// Ensure we have devfs inside the container to get dynamic loop
// loop devices inside the container.
if err := util.RunCmdSync("mount", "-t", "devtmpfs", "devtmpfs", "/dev"); err != nil {
return err
}

// Create a bind mount into our target location; we can't copy it because
// again we have to perserve the SELinux label.
if err := util.RunCmdSync("mount", "--bind", destPath, osbuildPath); err != nil {
return err
}
// NOTE: Don't add new code here, do it before the bind mount which acts as the final success indicator

return nil
}

Expand Down
Loading