Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: checkout code for testingfarm workflow first #39

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Dec 7, 2023

This is required apparently even when passing a git_ref to the testing farm github action. Sadly it was impossible to test this beforehand in the repo.

This is required apparently even when passing a `git_ref` to the
testing farm github action. Sadly it was impossible to test this
beforehand in the repo.
@mvo5 mvo5 marked this pull request as ready for review December 7, 2023 14:34
@mvo5
Copy link
Collaborator Author

mvo5 commented Dec 7, 2023

Sadly this needs to land first before we can be sure it works (or not) because in pull_request_target the workflow is always taken from the base branch for security reasons.

Copy link
Contributor

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvo5 mvo5 added this pull request to the merge queue Dec 7, 2023
Merged via the queue into osbuild:main with commit d2f6444 Dec 7, 2023
7 of 8 checks passed
@mvo5 mvo5 deleted the tmt-smoke-fix-tf branch December 8, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants