buildconfig: disable tests for undecoded keys for now #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a failing regression test for the following customization: ```toml [[customizations.filesystem]] mountpoint = "/" minsize = 1000 ``` which yields an error now: ``` 2024/09/24 09:08:34 error: cannot build manifest: cannot read config: cannot decode "/config.toml": unknown keys found: [customizations.filesystem.mountpoint customizations.filesystem.minsize customizations.filesystem.mountpoint customizations.filesystem.minsize] ```
This adds another layer of defense for issue#655, i.e. have a hand craftet toml that integration tests with bib as a smoke test.
|
An alterative upstream fix: BurntSushi/toml#426 (might be too naive, let's hear the maintainer :) |
This commit partially reverts PT#549 to unblock filesystem customizations in bib. This is a short term fix and we should revert and do something smarter like osbuild/images#951 or see if we can do better in the toml unmarshaling. But to unblock toml customizations this is a (IMHO) reasonable first step. Closes: osbuild#655
mvo5
force-pushed
the
short-term-fix-issue-655
branch
from
1c728d7 to
4701613
Compare
ondrejbudai
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially reverts PT#549 to unblock filesystem
customizations in bib.
This is a short term fix and we should revert and do something
smarter like osbuild/images#951 or see
if we can do better in the toml unmarshaling. But to unblock
toml customizations this is a (IMHO) reasonable first step.
Closes: #655